add UnitUtil class #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic1a434fda3a051c10e37190aaab22e9db466bb23
Change-Id: Ice09c3c01be6e12f74b889d28b9eae93c5fa6a78
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
============================================
+ Coverage 84.78% 85.24% +0.45%
- Complexity 767 795 +28
============================================
Files 60 61 +1
Lines 2209 2298 +89
Branches 325 341 +16
============================================
+ Hits 1873 1959 +86
+ Misses 191 190 -1
- Partials 145 149 +4
Continue to review full report at Codecov.
|
Linary
previously approved these changes
Mar 17, 2021
zhoney
requested changes
Mar 17, 2021
| (long) (755 * 1.024) * Bytes.PB); | ||
| Assert.assertEquals("7.75 EB", value); | ||
|
|
||
| // overflow |
| e.getMessage()); | ||
| }); | ||
|
|
||
| // invalid unit |
Change-Id: I67c7b38979b2c0603878d48929247ec0282d10d9
zhoney
approved these changes
Mar 19, 2021
Linary
approved these changes
Mar 19, 2021
aidanBurton
reviewed
Mar 21, 2021
| Assert.assertEquals(0L, UnitUtil.bytesFromReadableString("0 KB")); | ||
| Assert.assertEquals(Bytes.KB * 1L, | ||
| UnitUtil.bytesFromReadableString("1 KB")); | ||
| Assert.assertEquals((long) (Bytes.KB * 3.14), |
There was a problem hiding this comment.
I detect that this code is problematic. According to the Bad practice (BAD_PRACTICE), CNT: Rough value of known constant found (CNT_ROUGH_CONSTANT_VALUE).
It's recommended to use the predefined library constant for code clarity and better precision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic1a434fda3a051c10e37190aaab22e9db466bb23